Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
🦋 Changeset detectedLatest commit: 7670bd5 The changes in this PR will be included in the next version bump. This PR includes changesets to release 3 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
@proofkit/better-auth
@proofkit/fmdapi
@proofkit/fmodata
@proofkit/typegen
@proofkit/webviewer
commit: |
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Path: .coderabbit.yaml Review profile: CHILL Plan: Pro Run ID: 📒 Files selected for processing (4)
🚧 Files skipped from review as they are similar to previous changes (4)
📝 WalkthroughWalkthroughAdds adapter-level ChangesWebViewerAdapter batching and adapter-level pagination hooks
Estimated code review effort🎯 4 (Complex) | ⏱️ ~60 minutes 🚥 Pre-merge checks | ✅ 4 | ❌ 1❌ Failed checks (1 warning)
✅ Passed checks (4 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches📝 Generate docstrings
🧪 Generate unit tests (beta)
Comment |
There was a problem hiding this comment.
Actionable comments posted: 3
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Inline comments:
In `@packages/fmdapi/src/client.ts`:
- Around line 170-194: Normalize the sort input in `find` the same way `list`
does: in `packages/fmdapi/src/client.ts` within the `find`/`findAll`
request-building logic, detect when `params.sort` is a single object and wrap it
into an array before returning `params`. Keep the existing handling for `query`,
`offset`, and `dateformats`, and make sure the returned `FindOptions["data"]`
always receives `sort` in the array form expected by the downstream API.
In `@packages/webviewer/src/adapter.ts`:
- Around line 71-73: `maxSize` is only clamped with `Math.max`, so `NaN` or
other non-finite inputs can still flow through and break the drain loop in the
batch handling path. Update the batch-options normalization in `adapter.ts` so
the logic that computes `batch.maxSize` validates the value before clamping,
falling back to `DEFAULT_BATCH_MAX_SIZE` for `NaN`, `Infinity`, and similar
invalid inputs; apply the same fix to the other `maxSize` assignment in the
file’s second batch helper as well.
In `@packages/webviewer/tests/adapter.test.ts`:
- Line 1: The test is importing adapter types through a deep build-output path,
which bypasses the package export map. Update the import in adapter.test.ts to
use the exported subpath from `@proofkit/fmdapi/adapters/core` instead of the
dist/esm path, keeping the same FindOptions, ListOptions, and UpdateOptions type
references.
🪄 Autofix (Beta)
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: Path: .coderabbit.yaml
Review profile: CHILL
Plan: Pro
Run ID: 33f5ba46-84b0-4369-b420-2c4329ee9fa5
📒 Files selected for processing (7)
.changeset/quick-bats-queue.mdapps/docs/content/docs/webviewer/fmdapi.mdxpackages/fmdapi/src/adapters/core.tspackages/fmdapi/src/client.tspackages/fmdapi/tests/client-methods.test.tspackages/webviewer/src/adapter.tspackages/webviewer/tests/adapter.test.ts
|
Superseded by #293 on codex/webviewer-batching so fm26 can stay focused on docs. |
Summary:
Test:
Summary by CodeRabbit
listAllandfindAllsupport for more efficient bulk pagination.@proofkit/webviewerand@proofkit/fmdapi.